en/examples/minikube/Dockerfile: modify CMD to use exec form. (#18618)

Quote from https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#cmd:
%
CMD should almost always be used in the form of CMD ["executable", "param1", "param2"…]
%
This is because shell form doesn't pass the signal to an executable and it leads a longer shutdown time as Docker has to kill a process after some timeout. See for details: https://docs.docker.com/engine/reference/builder/#shell-form-entrypoint-example

An example on official NodeJS site is also uses that form: https://nodejs.org/de/docs/guides/nodejs-docker-webapp/#creating-a-dockerfile

This commit is contained in:

Slava Semushin

2020-01-11 18:23:37 +00:00

committed by

Kubernetes Prow Robot

parent 78dad3ceb6

commit 55ee59477e

1 changed files with 1 additions and 1 deletions

									
										content/en/examples/minikube/Dockerfile
									
		+1
		-1
	
												View File
												
				@@ -1,4 +1,4 @@

				FROM node:6.14.2

				EXPOSE 8080

				COPY server.js .

				CMD node server.js

				CMD [ "node", "server.js" ]