From 55ee59477ec2b82df778b16e4293ecc89bdacdb3 Mon Sep 17 00:00:00 2001 From: Slava Semushin Date: Sat, 11 Jan 2020 18:23:37 +0000 Subject: [PATCH] en/examples/minikube/Dockerfile: modify CMD to use exec form. (#18618) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Quote from https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#cmd: % CMD should almost always be used in the form of CMD ["executable", "param1", "param2"…] % This is because shell form doesn't pass the signal to an executable and it leads a longer shutdown time as Docker has to kill a process after some timeout. See for details: https://docs.docker.com/engine/reference/builder/#shell-form-entrypoint-example An example on official NodeJS site is also uses that form: https://nodejs.org/de/docs/guides/nodejs-docker-webapp/#creating-a-dockerfile --- content/en/examples/minikube/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en/examples/minikube/Dockerfile b/content/en/examples/minikube/Dockerfile index 1fe745295a..dd58cb7e75 100644 --- a/content/en/examples/minikube/Dockerfile +++ b/content/en/examples/minikube/Dockerfile @@ -1,4 +1,4 @@ FROM node:6.14.2 EXPOSE 8080 COPY server.js . -CMD node server.js +CMD [ "node", "server.js" ]