Misty Linville
5ae0d0dd8d
* Reorganize docs contrib guide * Address first round of feedback from Brad, Jared * Standardize on 'SIG Docs' * Address more feedback * Rewrites to participating.md * Tweak navigation titles * Document PR Wrangler * Document SIG Docs chairperson * Fix codeblock that shows how to use <codenew> It was being interpreted as a Hugo shortcode.
19 lines
701 B
Markdown
Executable File
19 lines
701 B
Markdown
Executable File
---
|
|
title: Approver
|
|
id: approver
|
|
date: 2018-04-12
|
|
full_link:
|
|
short_description: >
|
|
A person who can review and approve Kubernetes code contributions.
|
|
|
|
aka:
|
|
tags:
|
|
- community
|
|
---
|
|
A person who can review and approve Kubernetes code contributions.
|
|
|
|
<!--more-->
|
|
|
|
While code review is focused on code quality and correctness, approval is focused on the holistic acceptance of a contribution. Holistic acceptance includes backwards/forwards compatibility, adhering to API and flag conventions, subtle performance and correctness issues, interactions with other parts of the system, and others. Approver status is scoped to a part of the codebase. Approvers were previously referred to as maintainers.
|
|
|