Files
Slava Semushin 55ee59477e en/examples/minikube/Dockerfile: modify CMD to use exec form. (#18618)
Quote from https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#cmd:
%
CMD should almost always be used in the form of CMD ["executable", "param1", "param2"…]
%
This is because shell form doesn't pass the signal to an executable and it leads a longer shutdown time as Docker has to kill a process after some timeout. See for details: https://docs.docker.com/engine/reference/builder/#shell-form-entrypoint-example

An example on official NodeJS site is also uses that form: https://nodejs.org/de/docs/guides/nodejs-docker-webapp/#creating-a-dockerfile
2020-01-11 10:23:37 -08:00
..
2019-11-26 16:45:21 -08:00
2018-07-11 08:43:25 -07:00
2018-07-11 08:43:25 -07:00

Note: These tests are importing code from kubernetes that isn't really meant to be used outside the repo. This causes vendoring problems. As a result, we have to work around those with these lines in the travis config:

- rm $GOPATH/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery
- rm $GOPATH/src/k8s.io/kubernetes/vendor/k8s.io/apiserver
- rm $GOPATH/src/k8s.io/kubernetes/vendor/k8s.io/client-go
- cp -r $GOPATH/src/k8s.io/kubernetes/vendor/* $GOPATH/src/
- rm -rf $GOPATH/src/k8s.io/kubernetes/vendor/*
- cp -r $GOPATH/src/k8s.io/kubernetes/staging/src/* $GOPATH/src/