13 KiB
layout, title
| layout | title |
|---|---|
| docwithnav | Development Guide |
Development Guide
Releases and Official Builds
Official releases are built in Docker containers. Details are here. You can do simple builds and development with just a local Docker installation. If want to build go locally outside of docker, please continue below.
Go development environment
Kubernetes is written in Go programming language. If you haven't set up Go development environment, please follow this instruction to install go tool and set up GOPATH. Ensure your version of Go is at least 1.3.
Git Setup
Below, we outline one of the more common git workflows that core developers use. Other git workflows are also valid.
Visual overview
Fork the main repository
- Go to https://github.com/kubernetes/kubernetes
- Click the "Fork" button (at the top right)
Clone your fork
The commands below require that you have $GOPATH set ($GOPATH docs). We highly recommend you put Kubernetes' code into your GOPATH. Note: the commands below will not work if there is more than one directory in your $GOPATH.
{% highlight sh %} {% raw %} mkdir -p $GOPATH/src/k8s.io cd $GOPATH/src/k8s.io
Replace "$YOUR_GITHUB_USERNAME" below with your github username
git clone https://github.com/$YOUR_GITHUB_USERNAME/kubernetes.git cd kubernetes git remote add upstream 'https://github.com/kubernetes/kubernetes.git' {% endraw %} {% endhighlight %}
Create a branch and make changes
{% highlight sh %} {% raw %} git checkout -b myfeature
Make your code changes
{% endraw %} {% endhighlight %}
Keeping your development fork in sync
{% highlight sh %} {% raw %} git fetch upstream git rebase upstream/master {% endraw %} {% endhighlight %}
Note: If you have write access to the main repository at github.com/kubernetes/kubernetes, you should modify your git configuration so that you can't accidentally push to upstream:
{% highlight sh %} {% raw %} git remote set-url --push upstream no_push {% endraw %} {% endhighlight %}
Committing changes to your fork
{% highlight sh %} {% raw %} git commit git push -f origin myfeature {% endraw %} {% endhighlight %}
Creating a pull request
- Visit https://github.com/$YOUR_GITHUB_USERNAME/kubernetes
- Click the "Compare and pull request" button next to your "myfeature" branch.
- Check out the pull request process for more details
When to retain commits and when to squash
Upon merge, all git commits should represent meaningful milestones or units of work. Use commits to add clarity to the development and review process.
Before merging a PR, squash any "fix review feedback", "typo", and "rebased" sorts of commits. It is not imperative that every commit in a PR compile and pass tests independently, but it is worth striving for. For mass automated fixups (e.g. automated doc formatting), use one or more commits for the changes to tooling and a final commit to apply the fixup en masse. This makes reviews much easier.
See Faster Reviews for more details.
godep and dependency management
Kubernetes uses godep to manage dependencies. It is not strictly required for building Kubernetes but it is required when managing dependencies under the Godeps/ tree, and is required by a number of the build and test scripts. Please make sure that godep is installed and in your $PATH.
Installing godep
There are many ways to build and host go binaries. Here is an easy way to get utilities like godep installed:
-
Ensure that mercurial is installed on your system. (some of godep's dependencies use the mercurial source control system). Use
apt-get install mercurialoryum install mercurialon Linux, or brew.sh on OS X, or download directly from mercurial. -
Create a new GOPATH for your tools and install godep:
{% highlight sh %} {% raw %} export GOPATH=$HOME/go-tools mkdir -p $GOPATH go get github.com/tools/godep {% endraw %} {% endhighlight %}
- Add $GOPATH/bin to your path. Typically you'd add this to your ~/.profile:
{% highlight sh %} {% raw %} export GOPATH=$HOME/go-tools export PATH=$PATH:$GOPATH/bin {% endraw %} {% endhighlight %}
Using godep
Here's a quick walkthrough of one way to use godeps to add or update a Kubernetes dependency into Godeps/_workspace. For more details, please see the instructions in godep's documentation.
- Devote a directory to this endeavor:
Devoting a separate directory is not required, but it is helpful to separate dependency updates from other changes.
{% highlight sh %} {% raw %} export KPATH=$HOME/code/kubernetes mkdir -p $KPATH/src/k8s.io/kubernetes cd $KPATH/src/k8s.io/kubernetes git clone https://path/to/your/fork .
Or copy your existing local repo here. IMPORTANT: making a symlink doesn't work.
{% endraw %} {% endhighlight %}
- Set up your GOPATH.
{% highlight sh %} {% raw %}
Option A: this will let your builds see packages that exist elsewhere on your system.
export GOPATH=$KPATH:$GOPATH
Option B: This will not let your local builds see packages that exist elsewhere on your system.
export GOPATH=$KPATH
Option B is recommended if you're going to mess with the dependencies.
{% endraw %} {% endhighlight %}
- Populate your new GOPATH.
{% highlight sh %} {% raw %} cd $KPATH/src/k8s.io/kubernetes godep restore {% endraw %} {% endhighlight %}
- Next, you can either add a new dependency or update an existing one.
{% highlight sh %} {% raw %}
To add a new dependency, do:
cd $KPATH/src/k8s.io/kubernetes go get path/to/dependency
Change code in Kubernetes to use the dependency.
godep save ./...
To update an existing dependency, do:
cd $KPATH/src/k8s.io/kubernetes go get -u path/to/dependency
Change code in Kubernetes accordingly if necessary.
godep update path/to/dependency/... {% endraw %} {% endhighlight %}
If go get -u path/to/dependency fails with compilation errors, instead try go get -d -u path/to/dependency
to fetch the dependencies without compiling them. This can happen when updating the cadvisor dependency.
- Before sending your PR, it's a good idea to sanity check that your Godeps.json file is ok by running hack/verify-godeps.sh
If hack/verify-godeps.sh fails after a godep update, it is possible that a transitive dependency was added or removed but not
updated by godeps. It then may be necessary to perform a godep save ./... to pick up the transitive dependency changes.
It is sometimes expedient to manually fix the /Godeps/godeps.json file to minimize the changes.
Please send dependency updates in separate commits within your PR, for easier reviewing.
Hooks
Before committing any changes, please link/copy these hooks into your .git directory. This will keep you from accidentally committing non-gofmt'd go code.
{% highlight sh %} {% raw %} cd kubernetes/.git/hooks/ ln -s ../../hooks/pre-commit . {% endraw %} {% endhighlight %}
Unit tests
{% highlight sh %} {% raw %} cd kubernetes hack/test-go.sh {% endraw %} {% endhighlight %}
Alternatively, you could also run:
{% highlight sh %} {% raw %} cd kubernetes godep go test ./... {% endraw %} {% endhighlight %}
If you only want to run unit tests in one package, you could run godep go test under the package directory. For example, the following commands will run all unit tests in package kubelet:
{% highlight console %} {% raw %} $ cd kubernetes # step into the kubernetes directory. $ cd pkg/kubelet $ godep go test
some output from unit tests
PASS ok k8s.io/kubernetes/pkg/kubelet 0.317s {% endraw %} {% endhighlight %}
Coverage
Currently, collecting coverage is only supported for the Go unit tests.
To run all unit tests and generate an HTML coverage report, run the following:
{% highlight sh %} {% raw %} cd kubernetes KUBE_COVER=y hack/test-go.sh {% endraw %} {% endhighlight %}
At the end of the run, an the HTML report will be generated with the path printed to stdout.
To run tests and collect coverage in only one package, pass its relative path under the kubernetes directory as an argument, for example:
{% highlight sh %} {% raw %} cd kubernetes KUBE_COVER=y hack/test-go.sh pkg/kubectl {% endraw %} {% endhighlight %}
Multiple arguments can be passed, in which case the coverage results will be combined for all tests run.
Coverage results for the project can also be viewed on Coveralls, and are continuously updated as commits are merged. Additionally, all pull requests which spawn a Travis build will report unit test coverage results to Coveralls. Coverage reports from before the Kubernetes Github organization was created can be found here.
Integration tests
You need an etcd in your path, please make sure it is installed and in your $PATH.
{% highlight sh %} {% raw %} cd kubernetes hack/test-integration.sh {% endraw %} {% endhighlight %}
End-to-End tests
You can run an end-to-end test which will bring up a master and two nodes, perform some tests, and then tear everything down. Make sure you have followed the getting started steps for your chosen cloud platform (which might involve changing the KUBERNETES_PROVIDER environment variable to something other than "gce".
{% highlight sh %} {% raw %} cd kubernetes hack/e2e-test.sh {% endraw %} {% endhighlight %}
Pressing control-C should result in an orderly shutdown but if something goes wrong and you still have some VMs running you can force a cleanup with this command:
{% highlight sh %} {% raw %} go run hack/e2e.go --down {% endraw %} {% endhighlight %}
Flag options
See the flag definitions in hack/e2e.go for more options, such as reusing an existing cluster, here is an overview:
{% highlight sh %} {% raw %}
Build binaries for testing
go run hack/e2e.go --build
Create a fresh cluster. Deletes a cluster first, if it exists
go run hack/e2e.go --up
Create a fresh cluster at a specific release version.
go run hack/e2e.go --up --version=0.7.0
Test if a cluster is up.
go run hack/e2e.go --isup
Push code to an existing cluster
go run hack/e2e.go --push
Push to an existing cluster, or bring up a cluster if it's down.
go run hack/e2e.go --pushup
Run all tests
go run hack/e2e.go --test
Run tests matching the regex "Pods.*env"
go run hack/e2e.go -v -test --test_args="--ginkgo.focus=Pods.*env"
Alternately, if you have the e2e cluster up and no desire to see the event stream, you can run ginkgo-e2e.sh directly:
hack/ginkgo-e2e.sh --ginkgo.focus=Pods.*env {% endraw %} {% endhighlight %}
Combining flags
{% highlight sh %} {% raw %}
Flags can be combined, and their actions will take place in this order:
-build, -push|-up|-pushup, -test|-tests=..., -down
e.g.:
go run hack/e2e.go -build -pushup -test -down
-v (verbose) can be added if you want streaming output instead of only
seeing the output of failed commands.
-ctl can be used to quickly call kubectl against your e2e cluster. Useful for
cleaning up after a failed test or viewing logs. Use -v to avoid suppressing
kubectl output.
go run hack/e2e.go -v -ctl='get events' go run hack/e2e.go -v -ctl='delete pod foobar' {% endraw %} {% endhighlight %}
Conformance testing
End-to-end testing, as described above, is for development distributions. A conformance test is used on a versioned distro.
The conformance test runs a subset of the e2e-tests against a manually-created cluster. It does not require support for up/push/down and other operations. To run a conformance test, you need to know the IP of the master for your cluster and the authorization arguments to use. The conformance test is intended to run against a cluster at a specific binary release of Kubernetes. See conformance-test.sh.
Testing out flaky tests
Regenerating the CLI documentation
{% highlight sh %} {% raw %} hack/update-generated-docs.sh {% endraw %} {% endhighlight %}
