From db774186b57e1cd9a9cc766a313533b95a2b7337 Mon Sep 17 00:00:00 2001 From: gparvind Date: Tue, 20 Nov 2018 10:25:24 +0530 Subject: [PATCH] yaml code formatting fix for v1.12.0-rc.1 changelog (#11105) --- content/en/docs/setup/release/notes.md | 147 +++++++++++++------------ 1 file changed, 77 insertions(+), 70 deletions(-) diff --git a/content/en/docs/setup/release/notes.md b/content/en/docs/setup/release/notes.md index b7301f7e58..c79d745f1b 100644 --- a/content/en/docs/setup/release/notes.md +++ b/content/en/docs/setup/release/notes.md @@ -167,76 +167,83 @@ filename | sha256 hash ### Action Required * Service events are now added in azure-cloud-provider for easily identify the underground errors of Azure API. ([#68212](https://github.com/kubernetes/kubernetes/pull/68212), [@feiskyer](https://github.com/feiskyer)) - * Action required: The following clusterrole and clusterrolebinding should be applied: - * kind: List - * apiVersion: v1 - * items: - * - apiVersion: rbac.authorization.k8s.io/v1 - * kind: ClusterRole - * metadata: - * labels: - * kubernetes.io/cluster-service: "true" - * name: system:azure-cloud-provider - * rules: - * - apiGroups: [""] - * resources: ["events"] - * verbs: - * - create - * - patch - * - update - * - apiVersion: rbac.authorization.k8s.io/v1 - * kind: ClusterRoleBinding - * metadata: - * labels: - * kubernetes.io/cluster-service: "true" - * name: system:azure-cloud-provider - * roleRef: - * apiGroup: rbac.authorization.k8s.io - * kind: ClusterRole - * name: system:azure-cloud-provider - * subjects: - * - kind: ServiceAccount - * name: azure-cloud-provider - * namespace: kube-system - * If the clusterrole with same has already been provisioned (e.g. for accessing azurefile secrets), then the above yaml should be merged togather, e.g. - * kind: List - * apiVersion: v1 - * items: - * - apiVersion: rbac.authorization.k8s.io/v1 - * kind: ClusterRole - * metadata: - * labels: - * kubernetes.io/cluster-service: "true" - * name: system:azure-cloud-provider - * rules: - * - apiGroups: [""] - * resources: ["events"] - * verbs: - * - create - * - patch - * - update - * - apiGroups: [""] - * resources: ["secrets"] - * verbs: - * - get - * - create - * - apiVersion: rbac.authorization.k8s.io/v1 - * kind: ClusterRoleBinding - * metadata: - * labels: - * kubernetes.io/cluster-service: "true" - * name: system:azure-cloud-provider - * roleRef: - * apiGroup: rbac.authorization.k8s.io - * kind: ClusterRole - * name: system:azure-cloud-provider - * subjects: - * - kind: ServiceAccount - * name: azure-cloud-provider - * namespace: kube-system - * - kind: ServiceAccount - * name: persistent-volume-binder - * namespace: kube-system + * Action required: The following clusterrole and clusterrolebinding should be applied: + + ```yaml + kind: List + apiVersion: v1 + items: + - apiVersion: rbac.authorization.k8s.io/v1 + kind: ClusterRole + metadata: + labels: + kubernetes.io/cluster-service: "true" + name: system:azure-cloud-provider + rules: + - apiGroups: [""] + resources: ["events"] + verbs: + - create + - patch + - update + - apiVersion: rbac.authorization.k8s.io/v1 + kind: ClusterRoleBinding + metadata: + labels: + kubernetes.io/cluster-service: "true" + name: system:azure-cloud-provider + roleRef: + apiGroup: rbac.authorization.k8s.io + kind: ClusterRole + name: system:azure-cloud-provider + subjects: + - kind: ServiceAccount + name: azure-cloud-provider + namespace: kube-system + ``` + + * If the clusterrole with same has already been provisioned (e.g. for accessing azurefile secrets), then the above yaml should be merged together, e.g. + + ```yaml + kind: List + apiVersion: v1 + items: + - apiVersion: rbac.authorization.k8s.io/v1 + kind: ClusterRole + metadata: + labels: + kubernetes.io/cluster-service: "true" + name: system:azure-cloud-provider + rules: + - apiGroups: [""] + resources: ["events"] + verbs: + - create + - patch + - update + - apiGroups: [""] + resources: ["secrets"] + verbs: + - get + - create + - apiVersion: rbac.authorization.k8s.io/v1 + kind: ClusterRoleBinding + metadata: + labels: + kubernetes.io/cluster-service: "true" + name: system:azure-cloud-provider + roleRef: + apiGroup: rbac.authorization.k8s.io + kind: ClusterRole + name: system:azure-cloud-provider + subjects: + - kind: ServiceAccount + name: azure-cloud-provider + namespace: kube-system + - kind: ServiceAccount + name: persistent-volume-binder + namespace: kube-system + ``` ### Other notable changes