Apply suggestions from code review
Co-authored-by: Tim Bannister <tim@scalefactory.com>
This commit is contained in:
@@ -171,7 +171,7 @@ Approvers and SIG Docs leads are the only ones who can merge pull requests into
|
|||||||
- Visit the Netlify page preview for a PR to make sure things look good before approving.
|
- Visit the Netlify page preview for a PR to make sure things look good before approving.
|
||||||
|
|
||||||
- Participate in the [PR Wrangler rotation schedule](https://github.com/kubernetes/website/wiki/PR-Wranglers) for weekly rotations. SIG Docs expects all approvers to participate in this
|
- Participate in the [PR Wrangler rotation schedule](https://github.com/kubernetes/website/wiki/PR-Wranglers) for weekly rotations. SIG Docs expects all approvers to participate in this
|
||||||
rotation. See [PR wranglers](/docs/contribute/participating/pr-wranglers)
|
rotation. See [PR wranglers](/docs/contribute/participating/pr-wranglers/).
|
||||||
for more details.
|
for more details.
|
||||||
|
|
||||||
### Becoming an approver
|
### Becoming an approver
|
||||||
@@ -188,10 +188,10 @@ To apply:
|
|||||||
|
|
||||||
2. Assign the PR to one or more current SIG Docs approvers.
|
2. Assign the PR to one or more current SIG Docs approvers.
|
||||||
|
|
||||||
If approved, a SIG Docs lead adds you to the appropriate GitHub team. Once added, [K8s-ci-robot](https://github.com/kubernetes/test-infra/tree/master/prow#bots-home) assigns and suggests you as a reviewer on new pull requests.
|
If approved, a SIG Docs lead adds you to the appropriate GitHub team. Once added, [@k8s-ci-robot](https://github.com/kubernetes/test-infra/tree/master/prow#bots-home) assigns and suggests you as a reviewer on new pull requests.
|
||||||
|
|
||||||
## {{% heading "whatsnext" %}}
|
## {{% heading "whatsnext" %}}
|
||||||
|
|
||||||
Learn about specialized roles in SIG Docs:
|
Learn about specialized roles in SIG Docs:
|
||||||
|
|
||||||
- [PR wranglers](/docs/contribute/participating/pr-wranglers)
|
- [PR wranglers](/docs/contribute/participating/pr-wranglers)
|
||||||
|
|||||||
Reference in New Issue
Block a user