whentimeslows/website
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clean up label comments (#15397)

Browse Source
This commit is contained in:
Karen Bradshaw
2019-07-13 14:03:04 -04:00
committed by Kubernetes Prow Robot
parent 0e540e8dcb
commit 997242c871
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
content/en/docs/contribute/intermediate.md
+5 -5
View File
@@ -63,7 +63,7 @@ active participants.
Before you start reviewing PRs, make sure you are familiar with the Before you start reviewing PRs, make sure you are familiar with the
[Documentation Style Guide](/docs/contribute/style/style-guide/) [Documentation Style Guide](/docs/contribute/style/style-guide/)
and the [code of conduct](/community/code-of-conduct/) and the [code of conduct](/community/code-of-conduct/).
### Find a PR to review ### Find a PR to review
@@ -101,7 +101,7 @@ more information about the responsibilities of reviewers and approvers, see
indicates that a PR is technically accurate by leaving a `/lgtm` comment on indicates that a PR is technically accurate by leaving a `/lgtm` comment on
the PR. the PR.
{{< note >}}Don't add an `/lgtm` unless you are confident in the technical {{< note >}}Don't add a `/lgtm` unless you are confident in the technical
accuracy of the documentation modified or introduced in the PR.{{< /note >}} accuracy of the documentation modified or introduced in the PR.{{< /note >}}
- An approver reviews pull request content for docs quality and adherence to - An approver reviews pull request content for docs quality and adherence to
@@ -112,7 +112,7 @@ more information about the responsibilities of reviewers and approvers, see
approve a PR. To approve a PR, leave an `/approve` comment on the PR. approve a PR. To approve a PR, leave an `/approve` comment on the PR.
A PR is merged when it has both a `/lgtm` comment from anyone in the Kubernetes A PR is merged when it has both a `/lgtm` comment from anyone in the Kubernetes
organization and an `/approved` comment from an approver in the organization and an `/approve` comment from an approver in the
`sig-docs-maintainers` group, as long as it is not on hold and the PR author `sig-docs-maintainers` group, as long as it is not on hold and the PR author
has signed the CLA. has signed the CLA.
@@ -178,9 +178,9 @@ The ["Participating"](/docs/contribute/participating/#approvers) section contain
provide technical review. provide technical review.
- To prevent the PR from being merged, add `/hold`. This sets the - To prevent the PR from being merged, add `/hold`. This sets the
label `do-not-merge/hold`. label `do-not-merge/hold`.
- If a PR has no conflicts and has the `lgtm` and `approved` label but - If a PR has no conflicts and has the `lgtm` and `approve` labels but
no `hold` label, it is merged automatically. no `hold` label, it is merged automatically.
- If a PR has the `lgtm` and/or `approved` labels and new changes are - If a PR has the `lgtm` and/or `approve` labels and new changes are
detected, these labels are removed automatically. detected, these labels are removed automatically.
See See