From 9581abbe2e3c5ff6755dd2f4cb4ce372c7d90f1f Mon Sep 17 00:00:00 2001 From: chrismetz09 Date: Mon, 7 Feb 2022 11:16:05 -0800 Subject: [PATCH 1/3] Add Figure to text and caption method described in [How to use captions](https://kubernetes.io/docs/contribute/style/diagram-guide/#how-to-use-captions) --- .../en/docs/contribute/new-content/open-a-pr.md | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/content/en/docs/contribute/new-content/open-a-pr.md b/content/en/docs/contribute/new-content/open-a-pr.md index 548dbac5d0..d50d9a1629 100644 --- a/content/en/docs/contribute/new-content/open-a-pr.md +++ b/content/en/docs/contribute/new-content/open-a-pr.md @@ -28,7 +28,7 @@ If your changes are large, read [Work from a local fork](#fork-the-repo) to lear ## Changes using GitHub If you're less experienced with git workflows, here's an easier method of -opening a pull request. The figure below outlines the steps and the details follow. +opening a pull request. Figure 1 outlines the steps and the details follow. @@ -61,7 +61,7 @@ class tasks,tasks2 white class id1 k8s {{}} -***Figure - Steps for opening a PR using GitHub*** +Figure 1. Steps for opening a PR using GitHub*** 1. On the page where you see the issue, select the pencil icon at the top right. You can also scroll to the bottom of the page and select **Edit this page**. @@ -122,7 +122,7 @@ work from a local fork. Make sure you have [git](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git) installed on your computer. You can also use a git UI application. -The figure below shows the steps to follow when you work from a local fork. The details for each step follow. +Figure 2 shows the steps to follow when you work from a local fork. The details for each step follow. @@ -151,7 +151,8 @@ class 1,2,3,3a,4,5,6 grey class S,T spacewhite class changes,changes2 white {{}} -***Figure - Working from a local fork to make your changes*** + +Figure 2. Working from a local fork to make your changes*** ### Fork the kubernetes/website repository @@ -353,7 +354,7 @@ Alternately, install and use the `hugo` command on your computer: ### Open a pull request from your fork to kubernetes/website {#open-a-pr} -The figure below shows the steps to open a PR from your fork to the K8s/website. The details follow. +Figure 3 shows the steps to open a PR from your fork to the K8s/website. The details follow. @@ -379,7 +380,8 @@ classDef white fill:#ffffff,stroke:#000,stroke-width:px,color:#000,font-weight:b class 1,2,3,4,5,6,7,8 grey class first,second white {{}} -***Figure - Steps to open a PR from your fork to the K8s/website*** + +Figure 3. Steps to open a PR from your fork to the K8s/website*** 1. In a web browser, go to the [`kubernetes/website`](https://github.com/kubernetes/website/) repository. 2. Select **New Pull Request**. From b66faef3f98e909e466722b60f31d9b85cf654ce Mon Sep 17 00:00:00 2001 From: chrismetz09 Date: Mon, 7 Feb 2022 13:15:19 -0800 Subject: [PATCH 2/3] removed *** at end of caption text --- content/en/docs/contribute/new-content/open-a-pr.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content/en/docs/contribute/new-content/open-a-pr.md b/content/en/docs/contribute/new-content/open-a-pr.md index d50d9a1629..5cec9164c4 100644 --- a/content/en/docs/contribute/new-content/open-a-pr.md +++ b/content/en/docs/contribute/new-content/open-a-pr.md @@ -61,7 +61,7 @@ class tasks,tasks2 white class id1 k8s {{}} -Figure 1. Steps for opening a PR using GitHub*** +Figure 1. Steps for opening a PR using GitHub 1. On the page where you see the issue, select the pencil icon at the top right. You can also scroll to the bottom of the page and select **Edit this page**. @@ -152,7 +152,7 @@ class S,T spacewhite class changes,changes2 white {{}} -Figure 2. Working from a local fork to make your changes*** +Figure 2. Working from a local fork to make your changes ### Fork the kubernetes/website repository @@ -381,7 +381,7 @@ class 1,2,3,4,5,6,7,8 grey class first,second white {{}} -Figure 3. Steps to open a PR from your fork to the K8s/website*** +Figure 3. Steps to open a PR from your fork to the K8s/website 1. In a web browser, go to the [`kubernetes/website`](https://github.com/kubernetes/website/) repository. 2. Select **New Pull Request**. From 37a47f2a94f99de261cb58718ce7a8956e63470c Mon Sep 17 00:00:00 2001 From: chrismetz09 Date: Mon, 7 Feb 2022 15:09:12 -0800 Subject: [PATCH 3/3] Add period after caption text --- content/en/docs/contribute/new-content/open-a-pr.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content/en/docs/contribute/new-content/open-a-pr.md b/content/en/docs/contribute/new-content/open-a-pr.md index 5cec9164c4..b974e3a0f0 100644 --- a/content/en/docs/contribute/new-content/open-a-pr.md +++ b/content/en/docs/contribute/new-content/open-a-pr.md @@ -61,7 +61,7 @@ class tasks,tasks2 white class id1 k8s {{}} -Figure 1. Steps for opening a PR using GitHub +Figure 1. Steps for opening a PR using GitHub. 1. On the page where you see the issue, select the pencil icon at the top right. You can also scroll to the bottom of the page and select **Edit this page**. @@ -152,7 +152,7 @@ class S,T spacewhite class changes,changes2 white {{}} -Figure 2. Working from a local fork to make your changes +Figure 2. Working from a local fork to make your changes. ### Fork the kubernetes/website repository @@ -381,7 +381,7 @@ class 1,2,3,4,5,6,7,8 grey class first,second white {{}} -Figure 3. Steps to open a PR from your fork to the K8s/website +Figure 3. Steps to open a PR from your fork to the K8s/website. 1. In a web browser, go to the [`kubernetes/website`](https://github.com/kubernetes/website/) repository. 2. Select **New Pull Request**.