whentimeslows/website
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Note to limit changes in PR to one language (#15773)

Browse Source 
* Updated Start Contributing docs asking to limit changes to one
language in each PR.

* Moved note about one language per PR to end of step 5.
This commit is contained in:
Max Kaminskiy
2019-08-15 20:30:33 -07:00
committed by Kubernetes Prow Robot
parent 73ef2c557b
commit 7fc8050389
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
content/en/docs/contribute/start.md
+4
View File
@@ -261,6 +261,10 @@ pull request if it detects that you pushed a new branch to your fork.
link for the `deploy/netlify` test, near the bottom of the page. It opens in link for the `deploy/netlify` test, near the bottom of the page. It opens in
the same browser window by default. the same browser window by default.
{{< note >}}
Please limit pull requests to one language per PR. For example, if you need to make an identical change to the same code sample in multiple languages, open a separate PR for each language.
{{< /note >}}
6. Wait for review. Generally, reviewers are suggested by the `k8s-ci-robot`. 6. Wait for review. Generally, reviewers are suggested by the `k8s-ci-robot`.
If a reviewer asks you to make changes, you can go to the **Files changed** If a reviewer asks you to make changes, you can go to the **Files changed**
tab and click the pencil icon on any files that have been changed by the tab and click the pencil icon on any files that have been changed by the