whentimeslows/website
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changed 'caBundle' description (#19341)

Browse Source 
It is not clear that the 'caBundle' field in the Mutating/Validating webhook object is used for client-side validation from the admission controller itself.
The comment which appears at the source code is much more clear --> https://github.com/kubernetes/api/blob/master/admissionregistration/v1beta1/types.go#L534-L537

My suggestion is to change the description to match the documentation which is IMO much more clear
This commit is contained in:
Tsahi Duek
2020-03-16 06:28:35 +02:00
committed by GitHub
parent a9719704e9
commit 5f496a6ce6
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
content/en/docs/reference/access-authn-authz/extensible-admission-controllers.md
+3 -3
View File
@@ -114,7 +114,7 @@ webhooks:
service: service:
namespace: "example-namespace" namespace: "example-namespace"
name: "example-service" name: "example-service"
caBundle: "Ci0tLS0tQk...<base64-encoded PEM bundle containing the CA that signed the webhook's serving certificate>...tLS0K" caBundle: "Ci0tLS0tQk...<`caBundle` is a PEM encoded CA bundle which will be used to validate the webhook's server certificate.>...tLS0K"
admissionReviewVersions: ["v1", "v1beta1"] admissionReviewVersions: ["v1", "v1beta1"]
sideEffects: None sideEffects: None
timeoutSeconds: 5 timeoutSeconds: 5
@@ -139,7 +139,7 @@ webhooks:
service: service:
namespace: "example-namespace" namespace: "example-namespace"
name: "example-service" name: "example-service"
caBundle: "Ci0tLS0tQk...<base64-encoded PEM bundle containing the CA that signed the webhook's serving certificate>...tLS0K" caBundle: "Ci0tLS0tQk...<`caBundle` is a PEM encoded CA bundle which will be used to validate the webhook's server certificate>...tLS0K"
admissionReviewVersions: ["v1beta1"] admissionReviewVersions: ["v1beta1"]
timeoutSeconds: 5 timeoutSeconds: 5
``` ```
@@ -1122,7 +1122,7 @@ kind: MutatingWebhookConfiguration
webhooks: webhooks:
- name: my-webhook.example.com - name: my-webhook.example.com
clientConfig: clientConfig:
caBundle: "Ci0tLS0tQk...<base64-encoded PEM bundle containing the CA that signed the webhook's serving certificate>...tLS0K" caBundle: "Ci0tLS0tQk...<`caBundle` is a PEM encoded CA bundle which will be used to validate the webhook's server certificate>...tLS0K"
service: service:
namespace: my-service-namespace namespace: my-service-namespace
name: my-service-name name: my-service-name