From 38a61d71601fbb594c6323bce5ff540204ee1f5f Mon Sep 17 00:00:00 2001 From: vikaschoudhary16 Date: Tue, 19 Dec 2017 12:02:44 +0530 Subject: [PATCH] Fix Extended Resources consumption documentation --- .../configuration/manage-compute-resources-container.md | 4 +++- .../configure-pod-container/extended-resource-pod-2.yaml | 2 ++ docs/tasks/configure-pod-container/extended-resource-pod.yaml | 2 ++ docs/tasks/configure-pod-container/extended-resource.md | 2 ++ 4 files changed, 9 insertions(+), 1 deletion(-) diff --git a/docs/concepts/configuration/manage-compute-resources-container.md b/docs/concepts/configuration/manage-compute-resources-container.md index 8508f6642a..23d709207b 100644 --- a/docs/concepts/configuration/manage-compute-resources-container.md +++ b/docs/concepts/configuration/manage-compute-resources-container.md @@ -507,7 +507,7 @@ JSON-Pointer. For more details, see {: .note} To consume an Extended Resource in a Pod, include the resource name as a key -in the `spec.containers[].resources.requests` map. +in the `spec.containers[].resources.limits` map in the container spec. **Note:** Extended resources cannot be overcommitted, so request and limit must be equal if both are present in a container spec. @@ -535,6 +535,8 @@ spec: requests: cpu: 2 example.com/foo: 1 + limits: + example.com/foo: 1 ``` ## Planned Improvements diff --git a/docs/tasks/configure-pod-container/extended-resource-pod-2.yaml b/docs/tasks/configure-pod-container/extended-resource-pod-2.yaml index 33dec523fb..9c15d9ec86 100644 --- a/docs/tasks/configure-pod-container/extended-resource-pod-2.yaml +++ b/docs/tasks/configure-pod-container/extended-resource-pod-2.yaml @@ -9,3 +9,5 @@ spec: resources: requests: example.com/dongle: 2 + limits: + example.com/dongle: 2 diff --git a/docs/tasks/configure-pod-container/extended-resource-pod.yaml b/docs/tasks/configure-pod-container/extended-resource-pod.yaml index e0df8c95b0..4fb3de740e 100644 --- a/docs/tasks/configure-pod-container/extended-resource-pod.yaml +++ b/docs/tasks/configure-pod-container/extended-resource-pod.yaml @@ -9,3 +9,5 @@ spec: resources: requests: example.com/dongle: 3 + limits: + example.com/dongle: 3 diff --git a/docs/tasks/configure-pod-container/extended-resource.md b/docs/tasks/configure-pod-container/extended-resource.md index 137144a1cd..3a5cedefea 100644 --- a/docs/tasks/configure-pod-container/extended-resource.md +++ b/docs/tasks/configure-pod-container/extended-resource.md @@ -59,6 +59,8 @@ kubectl describe pod extended-resource-demo The output shows dongle requests: ```yaml +Limits: + example.com/dongle: 3 Requests: example.com/dongle: 3 ```