merge master to 1.10, with fixes (#7682)
This commit is contained in:
committed by
k8s-ci-robot
parent
bb8c59a640
commit
44b51d6056
+4
-4
@@ -25,7 +25,7 @@ This renders the definition of the glossary term inside a `<div>`, preserving Ma
|
||||
|
||||
| Name | Default | Description |
|
||||
| --- | --- | --- |
|
||||
| `term_id` | N/A (Required) | The `id` of the glossary term whose definition will be used. (This `id` is the same as the filename of the term, i.e. `_data/glossary/<ID>.yml`.) |
|
||||
| `term_id` | Not Applicable (Required) | The `id` of the glossary term whose definition will be used. (This `id` is the same as the filename of the term, i.e. `_data/glossary/<ID>.yml`.) |
|
||||
| `length` | "short" | Specifies which term definition should be used ("short" for the `short-definition`, "long" for `long-description`, "all" when both should be included). |
|
||||
| `prepend` | "Service Catalog is" | A prefix which can be attached in front of a term's short definition (which is one or more sentence fragments). |
|
||||
|
||||
@@ -49,7 +49,7 @@ This renders the following:
|
||||
| Name | Default | Description |
|
||||
| --- | --- | --- |
|
||||
| `text` | the `name` of the glossary term | The text that the user will hover over to display the glossary definition. **You should include this if using the tooltip inside of a glossary term's YAML short-definition.** |
|
||||
| `term_id` | N/A (Required) | The `id` of the associated glossary term. (This `id` is the same as the filename of the term, i.e. `_data/glossary/<ID>.yml`.) |
|
||||
| `term_id` | Not Applicable (Required) | The `id` of the associated glossary term. (This `id` is the same as the filename of the term, i.e. `_data/glossary/<ID>.yml`.) |
|
||||
|
||||
#### (3) `glossary_injector` tag
|
||||
|
||||
@@ -73,6 +73,6 @@ This renders the following:
|
||||
| Name | Default | Description |
|
||||
| --- | --- | --- |
|
||||
| `text` | the `name` of the glossary term | The text that the user will hover over to display the glossary definition. |
|
||||
| `term_id` | N/A (Required) | The `id` of the glossary term whose definition will be used. (This `id` is the same as the filename of the term, i.e. `_data/glossary/<ID>.yml`.) |
|
||||
| `placeholder_id` | N/A (Required) | The `id` of the HTML element whose contents will be populated with the definition of `term_id` |
|
||||
| `term_id` | Not Applicable (Required) | The `id` of the glossary term whose definition will be used. (This `id` is the same as the filename of the term, i.e. `_data/glossary/<ID>.yml`.) |
|
||||
| `placeholder_id` | Not Applicable (Required) | The `id` of the HTML element whose contents will be populated with the definition of `term_id` |
|
||||
| `length` | "short" | Specifies which term definition should be used ("short" for the `short-definition`, "long" for `long-description`, "all" when both should be included). |
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
require 'pry'
|
||||
# See /_plugins/README.md for full documentation of these custom Jekyll tags
|
||||
module Jekyll
|
||||
module GlossaryTags
|
||||
@@ -89,7 +90,7 @@ module Jekyll
|
||||
gsub(NESTED_MARKDOWN_LINKS, '\2').
|
||||
strip
|
||||
|
||||
"<a class='glossary-tooltip' href='#{external_link}'>" \
|
||||
"<a class='glossary-tooltip' href='#{external_link}' target='_blank'>" \
|
||||
"#{@args[:text] || term_info["name"]}" \
|
||||
"<span class='tooltip-text'>" \
|
||||
"#{tooltip}" \
|
||||
|
||||
Reference in New Issue
Block a user