From 95577c1fa5d1f6a89507b0ca30cf834734bc5295 Mon Sep 17 00:00:00 2001 From: Edward Rosen <31105434+edwardrosen@users.noreply.github.com> Date: Tue, 29 Dec 2020 16:20:54 -0500 Subject: [PATCH 1/3] Update rbac.md The page renders the third bullet as a run-on sentence. I'm suggesting the example be placed in parentheses. --- content/en/docs/reference/access-authn-authz/rbac.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/en/docs/reference/access-authn-authz/rbac.md b/content/en/docs/reference/access-authn-authz/rbac.md index d3e6dc118e..7a31013002 100644 --- a/content/en/docs/reference/access-authn-authz/rbac.md +++ b/content/en/docs/reference/access-authn-authz/rbac.md @@ -86,8 +86,8 @@ Because ClusterRoles are cluster-scoped, you can also use them to grant access t * cluster-scoped resources (like {{< glossary_tooltip text="nodes" term_id="node" >}}) * non-resource endpoints (like `/healthz`) * namespaced resources (like Pods), across all namespaces - For example: you can use a ClusterRole to allow a particular user to run - `kubectl get pods --all-namespaces`. + (for example: you can use a ClusterRole to allow a particular user to run + `kubectl get pods --all-namespaces`) Here is an example of a ClusterRole that can be used to grant read access to {{< glossary_tooltip text="secrets" term_id="secret" >}} in any particular namespace, From 284d725ee0389632a992fb52220626052737a524 Mon Sep 17 00:00:00 2001 From: Edward Rosen <31105434+edwardrosen@users.noreply.github.com> Date: Fri, 8 Jan 2021 14:10:01 -0500 Subject: [PATCH 2/3] Update rbac.md I added a
after the end of the third bullet and backed out all of the other changes I suggested in the original pull request. I think this better matches the author's original intent. The only difference now between what's currently published and this edit is the line break coded after the third bullet. --- content/en/docs/reference/access-authn-authz/rbac.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content/en/docs/reference/access-authn-authz/rbac.md b/content/en/docs/reference/access-authn-authz/rbac.md index 7a31013002..a6af967ace 100644 --- a/content/en/docs/reference/access-authn-authz/rbac.md +++ b/content/en/docs/reference/access-authn-authz/rbac.md @@ -85,9 +85,9 @@ Because ClusterRoles are cluster-scoped, you can also use them to grant access t * cluster-scoped resources (like {{< glossary_tooltip text="nodes" term_id="node" >}}) * non-resource endpoints (like `/healthz`) -* namespaced resources (like Pods), across all namespaces - (for example: you can use a ClusterRole to allow a particular user to run - `kubectl get pods --all-namespaces`) +* namespaced resources (like Pods), across all namespaces
+ For example: you can use a ClusterRole to allow a particular user to run + `kubectl get pods --all-namespaces` Here is an example of a ClusterRole that can be used to grant read access to {{< glossary_tooltip text="secrets" term_id="secret" >}} in any particular namespace, From a37b8a9feef9a79b5578ef14fda406ac4317ab83 Mon Sep 17 00:00:00 2001 From: Edward Rosen <31105434+edwardrosen@users.noreply.github.com> Date: Tue, 12 Jan 2021 15:22:39 -0500 Subject: [PATCH 3/3] Update rbac.md I've deleted the line break. The example in line 89 now seems to render ok in the preview. Could you please take a look? --- content/en/docs/reference/access-authn-authz/rbac.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en/docs/reference/access-authn-authz/rbac.md b/content/en/docs/reference/access-authn-authz/rbac.md index a6af967ace..783f25621f 100644 --- a/content/en/docs/reference/access-authn-authz/rbac.md +++ b/content/en/docs/reference/access-authn-authz/rbac.md @@ -85,7 +85,7 @@ Because ClusterRoles are cluster-scoped, you can also use them to grant access t * cluster-scoped resources (like {{< glossary_tooltip text="nodes" term_id="node" >}}) * non-resource endpoints (like `/healthz`) -* namespaced resources (like Pods), across all namespaces
+* namespaced resources (like Pods), across all namespaces For example: you can use a ClusterRole to allow a particular user to run `kubectl get pods --all-namespaces`