From 7048041d14fef76c1a7e6308201ef8680b7b4fab Mon Sep 17 00:00:00 2001 From: Lorenzo Paris Date: Tue, 1 Sep 2020 16:47:11 -0700 Subject: [PATCH 1/5] Update storage-classes.md Adding vSphere CSI StorageClass example. --- .../docs/concepts/storage/storage-classes.md | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/content/en/docs/concepts/storage/storage-classes.md b/content/en/docs/concepts/storage/storage-classes.md index f2c8589db4..9926ffc973 100644 --- a/content/en/docs/concepts/storage/storage-classes.md +++ b/content/en/docs/concepts/storage/storage-classes.md @@ -415,6 +415,33 @@ This internal provisioner of OpenStack is deprecated. Please use [the external c ### vSphere +There are two types of provisioners for vSphere storage classes: + +- [CSI provisioner](#csi-provisioner): `csi.vsphere.vmware.com` +- [vCP provisioner](#vcp-provisioner): `kubernetes.io/vsphere-volume` + +In-tree provisioners are [deprecated](https://kubernetes.io/blog/2019/12/09/kubernetes-1-17-feature-csi-migration-beta/#why-are-we-migrating-in-tree-plugins-to-csi). For more information on the CSI provisioner, see [Kubernetes vSphere CSI Driver](https://vsphere-csi-driver.sigs.k8s.io/) and [vSphereVolume CSI migration](https://kubernetes.io/docs/concepts/storage/volumes/#csi-migration-5). + +#### CSI Provisioner + +The vSphere CSI StorageClass provisioner works with Tanzu Kubernetes clusters. + +``` +kind: StorageClass +apiVersion: storage.k8s.io/v1 +metadata: + name: example-vsphere-sc-csi + annotations: + storageclass.kubernetes.io/is-default-class: "true" +provisioner: csi.vsphere.vmware.com +parameters: + datastoreurl: "ds:///vmfs/volumes/vsan:52d8eb4842dbf493-41523be9cd4ff7b7/" +``` + +#### vCP Provisioner + +The following examples use the VMware Cloud Provider (vCP) StorageClass provisioner. + 1. Create a StorageClass with a user specified disk format. ```yaml From d3475e6a5c2db54c885d709882544427555c1c09 Mon Sep 17 00:00:00 2001 From: Lorenzo Paris Date: Wed, 9 Sep 2020 14:37:24 -0700 Subject: [PATCH 2/5] Update content/en/docs/concepts/storage/storage-classes.md Co-authored-by: Tim Bannister --- content/en/docs/concepts/storage/storage-classes.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/content/en/docs/concepts/storage/storage-classes.md b/content/en/docs/concepts/storage/storage-classes.md index 9926ffc973..25edf94aed 100644 --- a/content/en/docs/concepts/storage/storage-classes.md +++ b/content/en/docs/concepts/storage/storage-classes.md @@ -422,7 +422,7 @@ There are two types of provisioners for vSphere storage classes: In-tree provisioners are [deprecated](https://kubernetes.io/blog/2019/12/09/kubernetes-1-17-feature-csi-migration-beta/#why-are-we-migrating-in-tree-plugins-to-csi). For more information on the CSI provisioner, see [Kubernetes vSphere CSI Driver](https://vsphere-csi-driver.sigs.k8s.io/) and [vSphereVolume CSI migration](https://kubernetes.io/docs/concepts/storage/volumes/#csi-migration-5). -#### CSI Provisioner +#### CSI Provisioner {#vsphere-provisioner-csi} The vSphere CSI StorageClass provisioner works with Tanzu Kubernetes clusters. @@ -846,4 +846,3 @@ Delaying volume binding allows the scheduler to consider all of a Pod's scheduling constraints when choosing an appropriate PersistentVolume for a PersistentVolumeClaim. - From 09a658eeb5acf803f9b499fdb714a58c818f0635 Mon Sep 17 00:00:00 2001 From: unknown Date: Tue, 15 Sep 2020 12:59:42 -0700 Subject: [PATCH 3/5] Addressing feedback --- content/en/docs/concepts/storage/storage-classes.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/content/en/docs/concepts/storage/storage-classes.md b/content/en/docs/concepts/storage/storage-classes.md index 25edf94aed..5577208039 100644 --- a/content/en/docs/concepts/storage/storage-classes.md +++ b/content/en/docs/concepts/storage/storage-classes.md @@ -420,19 +420,19 @@ There are two types of provisioners for vSphere storage classes: - [CSI provisioner](#csi-provisioner): `csi.vsphere.vmware.com` - [vCP provisioner](#vcp-provisioner): `kubernetes.io/vsphere-volume` -In-tree provisioners are [deprecated](https://kubernetes.io/blog/2019/12/09/kubernetes-1-17-feature-csi-migration-beta/#why-are-we-migrating-in-tree-plugins-to-csi). For more information on the CSI provisioner, see [Kubernetes vSphere CSI Driver](https://vsphere-csi-driver.sigs.k8s.io/) and [vSphereVolume CSI migration](https://kubernetes.io/docs/concepts/storage/volumes/#csi-migration-5). +In-tree provisioners are [deprecated](/blog/2019/12/09/kubernetes-1-17-feature-csi-migration-beta/#why-are-we-migrating-in-tree-plugins-to-csi). For more information on the CSI provisioner, see [Kubernetes vSphere CSI Driver](https://vsphere-csi-driver.sigs.k8s.io/) and [vSphereVolume CSI migration](/docs/concepts/storage/volumes/#csi-migration-5). #### CSI Provisioner {#vsphere-provisioner-csi} The vSphere CSI StorageClass provisioner works with Tanzu Kubernetes clusters. -``` -kind: StorageClass +```yaml apiVersion: storage.k8s.io/v1 +kind: StorageClass metadata: name: example-vsphere-sc-csi annotations: - storageclass.kubernetes.io/is-default-class: "true" + storageclass.kubernetes.io/is-default-class: true provisioner: csi.vsphere.vmware.com parameters: datastoreurl: "ds:///vmfs/volumes/vsan:52d8eb4842dbf493-41523be9cd4ff7b7/" From 4c67cd640fae9f5b2aa8392b89d9f4ef91da02a0 Mon Sep 17 00:00:00 2001 From: unknown Date: Thu, 17 Sep 2020 10:59:31 -0700 Subject: [PATCH 4/5] Remove example, point to repo --- .../en/docs/concepts/storage/storage-classes.md | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/content/en/docs/concepts/storage/storage-classes.md b/content/en/docs/concepts/storage/storage-classes.md index 5577208039..d440794bf0 100644 --- a/content/en/docs/concepts/storage/storage-classes.md +++ b/content/en/docs/concepts/storage/storage-classes.md @@ -424,20 +424,8 @@ In-tree provisioners are [deprecated](/blog/2019/12/09/kubernetes-1-17-feature-c #### CSI Provisioner {#vsphere-provisioner-csi} -The vSphere CSI StorageClass provisioner works with Tanzu Kubernetes clusters. +The vSphere CSI StorageClass provisioner works with Tanzu Kubernetes clusters. For examples, refer to the [vSphere CSI repository](https://github.com/kubernetes-sigs/vsphere-csi-driver). -```yaml -apiVersion: storage.k8s.io/v1 -kind: StorageClass -metadata: - name: example-vsphere-sc-csi - annotations: - storageclass.kubernetes.io/is-default-class: true -provisioner: csi.vsphere.vmware.com -parameters: - datastoreurl: "ds:///vmfs/volumes/vsan:52d8eb4842dbf493-41523be9cd4ff7b7/" -``` - #### vCP Provisioner The following examples use the VMware Cloud Provider (vCP) StorageClass provisioner. From 82c612be234ad2dc9d65f4f814bfd85dc6aa7daa Mon Sep 17 00:00:00 2001 From: unknown Date: Thu, 17 Sep 2020 11:13:47 -0700 Subject: [PATCH 5/5] Added direct link --- content/en/docs/concepts/storage/storage-classes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en/docs/concepts/storage/storage-classes.md b/content/en/docs/concepts/storage/storage-classes.md index d440794bf0..59579b443c 100644 --- a/content/en/docs/concepts/storage/storage-classes.md +++ b/content/en/docs/concepts/storage/storage-classes.md @@ -424,7 +424,7 @@ In-tree provisioners are [deprecated](/blog/2019/12/09/kubernetes-1-17-feature-c #### CSI Provisioner {#vsphere-provisioner-csi} -The vSphere CSI StorageClass provisioner works with Tanzu Kubernetes clusters. For examples, refer to the [vSphere CSI repository](https://github.com/kubernetes-sigs/vsphere-csi-driver). +The vSphere CSI StorageClass provisioner works with Tanzu Kubernetes clusters. For an example, refer to the [vSphere CSI repository](https://raw.githubusercontent.com/kubernetes-sigs/vsphere-csi-driver/master/example/vanilla-k8s-file-driver/example-sc.yaml). #### vCP Provisioner