From c315df3c0f187e94979d7cc15b4d2dc8a7fdef98 Mon Sep 17 00:00:00 2001 From: Steven Pitts <25968054+makusu2@users.noreply.github.com> Date: Fri, 14 May 2021 12:12:48 -0400 Subject: [PATCH 1/3] Clarify what must be the same When reading these sentences, I thought that each pod must have the same values as each other pod. In other words, pod1's memory limit must equal pod2's memory limit. It looks like I misunderstood; "must be the same" means that the limit and request values on each individual pod must match. Clarify what "must be the same". --- .../docs/tasks/configure-pod-container/quality-service-pod.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/en/docs/tasks/configure-pod-container/quality-service-pod.md b/content/en/docs/tasks/configure-pod-container/quality-service-pod.md index 0e6a02af37..93204b86e0 100644 --- a/content/en/docs/tasks/configure-pod-container/quality-service-pod.md +++ b/content/en/docs/tasks/configure-pod-container/quality-service-pod.md @@ -45,8 +45,8 @@ kubectl create namespace qos-example For a Pod to be given a QoS class of Guaranteed: -* Every Container, including init containers, in the Pod must have a memory limit and a memory request, and they must be the same. -* Every Container, including init containers, in the Pod must have a CPU limit and a CPU request, and they must be the same. +* Every Container, including init containers, in the Pod must have a memory limit and a memory request, and the two values must be the same. +* Every Container, including init containers, in the Pod must have a CPU limit and a CPU request, and the two values must be the same. Here is the configuration file for a Pod that has one Container. The Container has a memory limit and a memory request, both equal to 200 MiB. The Container has a CPU limit and a CPU request, both equal to 700 milliCPU: From 010374113893b178910f1599f3b76bccaa9fda33 Mon Sep 17 00:00:00 2001 From: Steven Pitts <25968054+makusu2@users.noreply.github.com> Date: Wed, 19 May 2021 17:23:05 -0400 Subject: [PATCH 2/3] Update content/en/docs/tasks/configure-pod-container/quality-service-pod.md Co-authored-by: Tim Bannister --- .../tasks/configure-pod-container/quality-service-pod.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/content/en/docs/tasks/configure-pod-container/quality-service-pod.md b/content/en/docs/tasks/configure-pod-container/quality-service-pod.md index 93204b86e0..ca74cf2a47 100644 --- a/content/en/docs/tasks/configure-pod-container/quality-service-pod.md +++ b/content/en/docs/tasks/configure-pod-container/quality-service-pod.md @@ -45,7 +45,12 @@ kubectl create namespace qos-example For a Pod to be given a QoS class of Guaranteed: -* Every Container, including init containers, in the Pod must have a memory limit and a memory request, and the two values must be the same. +* Every Container in the Pod must have a memory limit and a memory request. +* For every Container in the Pod, the memory limit must equal the memory request. +* Every Container in the Pod must have a CPU limit and a CPU request. +* For every Container in the Pod, the CPU limit must equal the CPU request. + +These restrictions apply to init containers and app containers equally. * Every Container, including init containers, in the Pod must have a CPU limit and a CPU request, and the two values must be the same. Here is the configuration file for a Pod that has one Container. The Container has a memory limit and a @@ -273,4 +278,3 @@ kubectl delete namespace qos-example - From e72b6ace24f7a8297e2c5e6560f632ac1001d79b Mon Sep 17 00:00:00 2001 From: Steven Pitts <25968054+makusu2@users.noreply.github.com> Date: Thu, 20 May 2021 09:03:46 -0400 Subject: [PATCH 3/3] Update content/en/docs/tasks/configure-pod-container/quality-service-pod.md --- .../docs/tasks/configure-pod-container/quality-service-pod.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/content/en/docs/tasks/configure-pod-container/quality-service-pod.md b/content/en/docs/tasks/configure-pod-container/quality-service-pod.md index ca74cf2a47..abe6320563 100644 --- a/content/en/docs/tasks/configure-pod-container/quality-service-pod.md +++ b/content/en/docs/tasks/configure-pod-container/quality-service-pod.md @@ -51,7 +51,6 @@ For a Pod to be given a QoS class of Guaranteed: * For every Container in the Pod, the CPU limit must equal the CPU request. These restrictions apply to init containers and app containers equally. -* Every Container, including init containers, in the Pod must have a CPU limit and a CPU request, and the two values must be the same. Here is the configuration file for a Pod that has one Container. The Container has a memory limit and a memory request, both equal to 200 MiB. The Container has a CPU limit and a CPU request, both equal to 700 milliCPU: @@ -277,4 +276,3 @@ kubectl delete namespace qos-example -